-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Visualizer based on Polyscope #29
Conversation
I love this! I have only a comment. The "MapClosures View" is confusing right now. I would suggest to have another ImGui window open once the first loop is detected with a button there to switch to "MapClosures View". Then you can put there all the commands to visualize the closures. It would be easy to understand in my opinion and should not take so much to implement. |
Ok I implemented the double ImGui window for closures. Probably the only missing thing is to set the window size for the new one. Right now it is too big when it appears the first time. |
With the new commit the window size seems to be good. |
Thanks @l00p3 for your lovely visualization skills. I will test your upgrades soon and let you know. |
@l00p3 I have made the changes as discussed internally. Also tried to improve some bugs with matplotlib for density maps visualization. Can you please test and review these final changes before I merge this PR? |
Everything works fine. |
Thanks to @l00p3 we also upgrade the visualizer for MapClosures using the awesome polyscope library.