Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visualizer based on Polyscope #29

Merged
merged 8 commits into from
Aug 15, 2024
Merged

Visualizer based on Polyscope #29

merged 8 commits into from
Aug 15, 2024

Conversation

saurabh1002
Copy link
Collaborator

Thanks to @l00p3 we also upgrade the visualizer for MapClosures using the awesome polyscope library.

@saurabh1002 saurabh1002 added the enhancement New feature or request label Aug 14, 2024
@l00p3
Copy link
Contributor

l00p3 commented Aug 14, 2024

I love this!

I have only a comment. The "MapClosures View" is confusing right now. I would suggest to have another ImGui window open once the first loop is detected with a button there to switch to "MapClosures View". Then you can put there all the commands to visualize the closures. It would be easy to understand in my opinion and should not take so much to implement.
I can do it for you if you want.

python/map_closures/tools/visualizer.py Outdated Show resolved Hide resolved
python/map_closures/tools/visualizer.py Outdated Show resolved Hide resolved
@l00p3
Copy link
Contributor

l00p3 commented Aug 15, 2024

Ok I implemented the double ImGui window for closures. Probably the only missing thing is to set the window size for the new one. Right now it is too big when it appears the first time.
Hope you like it.

@l00p3
Copy link
Contributor

l00p3 commented Aug 15, 2024

With the new commit the window size seems to be good.
My job here is done.
Mr. Visualizer is ready for the next job.

@saurabh1002
Copy link
Collaborator Author

Thanks @l00p3 for your lovely visualization skills. I will test your upgrades soon and let you know.

@saurabh1002
Copy link
Collaborator Author

@l00p3 I have made the changes as discussed internally. Also tried to improve some bugs with matplotlib for density maps visualization. Can you please test and review these final changes before I merge this PR?

@l00p3
Copy link
Contributor

l00p3 commented Aug 15, 2024

Everything works fine.
polyscope.improve_world ++

@saurabh1002 saurabh1002 merged commit bee36c5 into main Aug 15, 2024
@saurabh1002 saurabh1002 deleted the new_visualizer branch August 15, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants