Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup python API #25

Merged
merged 12 commits into from
Jul 25, 2024
Merged

Cleanup python API #25

merged 12 commits into from
Jul 25, 2024

Conversation

saurabh1002
Copy link
Collaborator

  1. Use "Stub" classes for all optional stuff, avoid if else checks in pipeline
  2. Filter gt_closures based on overlap threshold directly in the function
  3. Use dataclass decorator for all suitable classes
  4. Save KISS poses in kitti format, easy for evaluations using evo
  5. Handle default config when no config file provided directly in load_config function

Copy link
Collaborator

@tizianoGuadagnino tizianoGuadagnino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastico

@tizianoGuadagnino tizianoGuadagnino merged commit 318673b into main Jul 25, 2024
@saurabh1002 saurabh1002 deleted the cleanup_python branch July 25, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants