Use a flag to track updates/deletes in SQL visitor #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitrytrager
added a commit
to mayak-bz/clickhouse-activerecord
that referenced
this pull request
Jan 20, 2025
* new-master: (77 commits) Use a flag to track updates/deletes instead of guessing (PNixx#188) Do not squish table definitions in schema dump. (PNixx#187) Add support for integer limits in map type (PNixx#178) Improve function dumps (PNixx#179) Reliably sort functions, views, and materialized views in schema (PNixx#181) Maintain primary key type specificity (PNixx#183) Support create table with request settings Support codec column PNixx#135, refactoring Add Array support to Map (PNixx#158) SchemaDumper adds materialized view destination (PNixx#159) Improve DB::Exception error handling (PNixx#165) Add blank line after create_function in schema (PNixx#170) Include column definitions in schema dump if the column name is not `id` (PNixx#173) Add support for LIMIT BY clause (PNixx#169) Add support for force `CREATE FUNCTION` (PNixx#146) Implement GROUP BY GROUPING SETS with new `group_by_grouping_sets` query method. (PNixx#161) fix for function creation in structure.sql (PNixx#166) fix schema dumper fix spec fix detect model primary key for older clickhouse versions ...
dmitrytrager
added a commit
to mayak-bz/clickhouse-activerecord
that referenced
this pull request
Jan 20, 2025
* new-master: (77 commits) Use a flag to track updates/deletes instead of guessing (PNixx#188) Do not squish table definitions in schema dump. (PNixx#187) Add support for integer limits in map type (PNixx#178) Improve function dumps (PNixx#179) Reliably sort functions, views, and materialized views in schema (PNixx#181) Maintain primary key type specificity (PNixx#183) Support create table with request settings Support codec column PNixx#135, refactoring Add Array support to Map (PNixx#158) SchemaDumper adds materialized view destination (PNixx#159) Improve DB::Exception error handling (PNixx#165) Add blank line after create_function in schema (PNixx#170) Include column definitions in schema dump if the column name is not `id` (PNixx#173) Add support for LIMIT BY clause (PNixx#169) Add support for force `CREATE FUNCTION` (PNixx#146) Implement GROUP BY GROUPING SETS with new `group_by_grouping_sets` query method. (PNixx#161) fix for function creation in structure.sql (PNixx#166) fix schema dumper fix spec fix detect model primary key for older clickhouse versions ...
dmitrytrager
added a commit
to mayak-bz/clickhouse-activerecord
that referenced
this pull request
Jan 21, 2025
* new-master: (77 commits) Use a flag to track updates/deletes instead of guessing (PNixx#188) Do not squish table definitions in schema dump. (PNixx#187) Add support for integer limits in map type (PNixx#178) Improve function dumps (PNixx#179) Reliably sort functions, views, and materialized views in schema (PNixx#181) Maintain primary key type specificity (PNixx#183) Support create table with request settings Support codec column PNixx#135, refactoring Add Array support to Map (PNixx#158) SchemaDumper adds materialized view destination (PNixx#159) Improve DB::Exception error handling (PNixx#165) Add blank line after create_function in schema (PNixx#170) Include column definitions in schema dump if the column name is not `id` (PNixx#173) Add support for LIMIT BY clause (PNixx#169) Add support for force `CREATE FUNCTION` (PNixx#146) Implement GROUP BY GROUPING SETS with new `group_by_grouping_sets` query method. (PNixx#161) fix for function creation in structure.sql (PNixx#166) fix schema dumper fix spec fix detect model primary key for older clickhouse versions ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a small refactor we did to remove guesswork. Especially
collector.value.include?(' UPDATE ')is prone to false positives, for example if you're working with an error column that logs query info, likeSELECT * FROM errors WHERE message ILIKE '%query failed: UPDATE table%'. It also just felt weird to read from the collector to try to figure out what to do next.