Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .test for Normal distribution #1

Merged
merged 5 commits into from
Dec 20, 2024
Merged

Add .test for Normal distribution #1

merged 5 commits into from
Dec 20, 2024

Conversation

jykr
Copy link

@jykr jykr commented Dec 18, 2024

Observation modeled to have error with Normal distribution with mean field error and identity link function. i.e.,

$$ y=X\beta + a + \epsilon $$

$$ \epsilon \sim \mathcal{N}(0, \mathrm{diag}(\vec{\sigma^2})) $$

Copy link
Collaborator

@ilia-kats ilia-kats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for this. Looks good in general (I've only had a cursory look at the _do_test implementation, I trust that it's correct), but a few things aren't clear to me (see the specific comments).

SpatialDE/_internal/score_test.py Outdated Show resolved Hide resolved
SpatialDE/_internal/score_test.py Outdated Show resolved Hide resolved
setup.cfg Outdated Show resolved Hide resolved
Copy link
Collaborator

@ilia-kats ilia-kats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now. Could you just run the black formatter on the code?

@ilia-kats ilia-kats merged commit 3703cef into PMBio:master Dec 20, 2024
1 check passed
@ilia-kats
Copy link
Collaborator

Great, thank you.

@jykr
Copy link
Author

jykr commented Dec 20, 2024

Awesome! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants