-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrating ZIPLN to PLNmodels #116
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erms, levels, etc was a pleasure)
…`ZIPLNfit-class`. - replace variational variance with variational standard deviation - No change made in code (potential typos highlighted in review)
- Change filename for consistency with similar files (about S3 methods)
- Change prototype of optimizers in ZIPLNfit to remove unused parameters - ditch intermediate variables `optim_new_*` in the outer loop - fix bug with S/S2 in `predict()`
mahendra-mariadassou
force-pushed
the
zipln
branch
from
January 23, 2024 09:36
121c426
to
86240ef
Compare
… during outer-loop
- bug already fixed by Julien - forgotten browser in optimizeVE_step
- bug fix: no contribution of ZI part to average counts - add "deflated" response type to predict to get predicted counts without scaling from the ZI part.
mahendra-mariadassou
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Zero inflation with V-EM by mean field approximation.
What is done
In progress
Latter