-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pb in the dimension of S for spherical model #79
Comments
Indeed, since the spherical model has just one parameter to describe the covariance matrix, the variational distribution used in different from the diagonal and fully parametrized models: for individual i, we use q(z_i) ~ N(m_i, s_i I_p) where m_i is a vector in R^p (the p variables) and s_i a scalar (we do not need p variational parameters to estimate a single model parameter right?). So a matrix S with size n x 1 is expected for this model. |
I thought that spherical was referring to Sigma. Does it imply that all S_i are spherical as well? |
Indeed, spherical refers to Sigma. I don't now if it necessarily implies that the variational distribution is spherical too. It is just that it sounded better this way, and more computationally efficient (the common rule being one model parameters = one variational parameters per sample). |
@scj-robin We now use the same variational distribution to approximate any type of covariance structure (spherical, diagonal, full) for consistency |
It seems that the matrix S returned by PLN has only one column for spherical covariance:
load('BarentsFish.Rdata')
fit <- PLN(count ~ 1, data=Data, control=list(covariance='spherical'))
dim(fit$var_par$S)
fit <- PLN(count ~ 1, data=Data, control=list(covariance='diagonal'))
dim(fit$var_par$S)
The text was updated successfully, but these errors were encountered: