Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(portal-web): 文件管理重命名模态框双击触发文件列表双击事件 #960

Merged
merged 2 commits into from
Nov 8, 2023

Conversation

Miracle575
Copy link
Contributor

@Miracle575 Miracle575 commented Nov 8, 2023

事件冒泡了触发了 table 上绑定的双击事件,将模态框阻止冒泡

Copy link

changeset-bot bot commented Nov 8, 2023

⚠️ No Changeset found

Latest commit: 3f62efc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Nov 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (35e026b) 68.57% compared to head (3f62efc) 68.57%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #960   +/-   ##
=======================================
  Coverage   68.57%   68.57%           
=======================================
  Files         134      134           
  Lines        3971     3971           
  Branches      528      528           
=======================================
  Hits         2723     2723           
  Misses       1150     1150           
  Partials       98       98           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Miracle575 Miracle575 requested a review from ddadaal November 8, 2023 09:38
@Miracle575 Miracle575 marked this pull request as ready for review November 8, 2023 09:38
@ddadaal ddadaal merged commit e50c921 into master Nov 8, 2023
10 checks passed
@ddadaal ddadaal deleted the fix-modal-click branch November 8, 2023 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants