Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(portal-web): 去掉 legacyBehavior,会影响 target=“_blank” 在新窗口或标签中打开链接的效果 #844

Merged
merged 2 commits into from
Sep 7, 2023

Conversation

tongchong
Copy link
Contributor

目前使用的next版本13.4.10,如果增加了legacyBehavior,会影响target="_blank"的核心效果(即在新窗口或标签中打开链接),此pr去掉FileManager中的该属性,保证能在打开终端时新开页面

@tongchong tongchong requested a review from ddadaal September 7, 2023 07:12
@changeset-bot
Copy link

changeset-bot bot commented Sep 7, 2023

🦋 Changeset detected

Latest commit: 81892d9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@scow/portal-web Patch
@scow/auth Patch
@scow/gateway Patch
@scow/mis-server Patch
@scow/mis-web Patch
@scow/portal-server Patch
@scow/cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@tongchong tongchong changed the title fix(portal-web): 去掉 legacyBehavior,会影响 target=\_blank 在新窗口或标签中打开链接的效果 fix(portal-web): 去掉 legacyBehavior,会影响 target=“_blank” 在新窗口或标签中打开链接的效果 Sep 7, 2023
@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (1269e3c) 70.68% compared to head (81892d9) 70.68%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #844   +/-   ##
=======================================
  Coverage   70.68%   70.68%           
=======================================
  Files         129      129           
  Lines        3643     3643           
  Branches      479      479           
=======================================
  Hits         2575     2575           
  Misses        976      976           
  Partials       92       92           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ddadaal ddadaal merged commit 154f5a8 into master Sep 7, 2023
@ddadaal ddadaal deleted the fix-link-legacyBehavior branch September 7, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants