feat: new install options: sshDir and extraEnvs #1422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 3680938 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
link89
changed the title
ddadaal
requested changes
Sep 9, 2024
apps/cli/src/compose/index.ts
Outdated
| @@ -160,7 +170,7 @@ export const createComposeSpec = (config: InstallConfigSchema) => { | |||
| const authVolumes = { | |||
| "/etc/hosts": "/etc/hosts", | |||
| "./config": "/etc/scow", | |||
| "~/.ssh": "/root/.ssh", | |||
| SSH_DIR: "/root/.ssh", | |||
There was a problem hiding this comment.
这里应该使用[SSH_DIR]，使用SSH_DIR变量的值作为key，而不是使用字符串"SSH_DIR"作为key
There was a problem hiding this comment.
fix, 在本地通过 npm run build 验证
ddadaal
approved these changes
Sep 10, 2024
|
非常感谢您的贡献！ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #1421 and #1423