-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: AI应用的工作目录和挂载点重复时报错 #1395
Merged
Merged
fix: AI应用的工作目录和挂载点重复时报错 #1395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 2491ed0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ddadaal
requested changes
Aug 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个检查在API层也做一下,如果出现工作目录和挂载点重复,就返回400并写错误提示告诉用户
ddadaal
added
Code-ChangeRequested
and removed
Code-ReviewRequested
Code Review Requested
labels
Aug 13, 2024
pkuhpc-review-bot
bot
added
Code-ReviewRequested
Code Review Requested
and removed
Code-ChangeRequested
labels
Aug 14, 2024
ddadaal
approved these changes
Aug 14, 2024
pkuhpc-review-bot
bot
added
Code-Approved
Code Review approved
ReadyForMerge
Ready for merge
and removed
Code-ReviewRequested
Code Review Requested
labels
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
之前挂载点和工作目录重复时会报错:
因为工作目录一定会被挂载,该目录再次添加作为挂载点会有问题
改动后前端不允许用户添加和工作目录一样的挂载点目录,提示用户:该路径已指定为工作目录,无需再设置为挂载点