Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: AI应用的工作目录和挂载点重复时报错 #1395

Merged
merged 4 commits into from
Aug 14, 2024

Conversation

OYX-1
Copy link
Contributor

@OYX-1 OYX-1 commented Aug 12, 2024

之前挂载点和工作目录重复时会报错:

img_v3_02dj_fe4f50a9-335e-4a1b-a654-f7d55e7fdb8g

因为工作目录一定会被挂载,该目录再次添加作为挂载点会有问题

改动后前端不允许用户添加和工作目录一样的挂载点目录,提示用户:该路径已指定为工作目录,无需再设置为挂载点

image

Copy link

changeset-bot bot commented Aug 12, 2024

🦋 Changeset detected

Latest commit: 2491ed0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@scow/ai Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@OYX-1 OYX-1 marked this pull request as ready for review August 13, 2024 02:08
@pkuhpc-review-bot pkuhpc-review-bot bot added the Code-ReviewRequested Code Review Requested label Aug 13, 2024
@pkuhpc-review-bot pkuhpc-review-bot bot requested a review from ddadaal August 13, 2024 02:09
Copy link
Member

@ddadaal ddadaal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个检查在API层也做一下,如果出现工作目录和挂载点重复,就返回400并写错误提示告诉用户

@ddadaal ddadaal added Code-ChangeRequested and removed Code-ReviewRequested Code Review Requested labels Aug 13, 2024
@OYX-1
Copy link
Contributor Author

OYX-1 commented Aug 14, 2024

这个检查在API层也做一下,如果出现工作目录和挂载点重复,就返回400并写错误提示告诉用户

之前就有了

image
image

@OYX-1 OYX-1 requested a review from ddadaal August 14, 2024 02:20
@pkuhpc-review-bot pkuhpc-review-bot bot added Code-ReviewRequested Code Review Requested and removed Code-ChangeRequested labels Aug 14, 2024
@pkuhpc-review-bot pkuhpc-review-bot bot added Code-Approved Code Review approved ReadyForMerge Ready for merge and removed Code-ReviewRequested Code Review Requested labels Aug 14, 2024
@ddadaal ddadaal merged commit 5ba5ebb into master Aug 14, 2024
9 checks passed
@ddadaal ddadaal deleted the fix-workDirectory-mountPoints branch August 14, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code-Approved Code Review approved ReadyForMerge Ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants