Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: 减少发版测试通知所需参数，增加发版成功通知 #1318

Merged
merged 2 commits into from
Jun 25, 2024
Merged

chore: 减少发版测试通知所需参数，增加发版成功通知 #1318

merged 2 commits into from
Jun 25, 2024

Conversation

Miracle575
Copy link
Contributor

No description provided.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jun 24, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 1cb5c2b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Miracle575 Miracle575 marked this pull request as ready for review June 24, 2024 07:29
@pkuhpc-review-bot pkuhpc-review-bot bot added the Code-ReviewRequested Code Review Requested label Jun 24, 2024
@pkuhpc-review-bot pkuhpc-review-bot bot requested a review from ddadaal June 24, 2024 07:29
ddadaal
ddadaal requested changes Jun 24, 2024
View reviewed changes
.github/workflows/tag-release.yaml Outdated
steps:
- name: Send Notification Request
run: |
curl -X POST http://47.96.27.236:8080/version/success \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个IP在两个文件中出现了，建议设置为secret

@pkuhpc-review-bot pkuhpc-review-bot bot added Code-ChangeRequested and removed Code-ReviewRequested Code Review Requested labels Jun 24, 2024
@pkuhpc-review-bot pkuhpc-review-bot bot added Code-Approved Code Review approved ReadyForMerge Ready for merge and removed Code-ChangeRequested labels Jun 25, 2024
@ddadaal ddadaal merged commit a7c733b into master Jun 25, 2024
9 checks passed
@ddadaal ddadaal deleted the chore-version-bot branch June 25, 2024 11:06
OYX-1 pushed a commit that referenced this pull request Jul 4, 2024
@Miracle575 @OYX-1
chore: 减少发版测试通知所需参数，增加发版成功通知 (#1318)
752508a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddadaal ddadaal ddadaal approved these changes

Assignees
No one assigned
Labels
Code-Approved Code Review approved ReadyForMerge Ready for merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Miracle575 @ddadaal