Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): 修复 octokit 依赖更新导致 cli 命令执行失败的问题 #1293

Merged
merged 2 commits into from
Jun 11, 2024

Conversation

piccaSun
Copy link
Contributor

@piccaSun piccaSun commented Jun 11, 2024

问题

#1251 中,octokit发生大版本更新导致octokit的导入出现问题, 通过require导入也无法解决
octokit/octokit.js#2674
image

octokit/core等不支持octokit.rest方法
image

修改

可回退octokit版本或者指定 octokit/rest进行修复

此PR指定依赖为 @octokit/rest 进行修复
修复后可正常运行cli命令
image

Copy link

changeset-bot bot commented Jun 11, 2024

🦋 Changeset detected

Latest commit: a1c5ab5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@scow/cli Patch
@scow/auth Patch
@scow/gateway Patch
@scow/mis-server Patch
@scow/mis-web Patch
@scow/portal-server Patch
@scow/portal-web Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@piccaSun piccaSun marked this pull request as ready for review June 11, 2024 10:03
@pkuhpc-review-bot pkuhpc-review-bot bot added the Code-ReviewRequested Code Review Requested label Jun 11, 2024
@pkuhpc-review-bot pkuhpc-review-bot bot requested a review from ddadaal June 11, 2024 10:03
@piccaSun
Copy link
Contributor Author

@ddadaal 请确认是对 #1251 中 octokit 版本进行回退, 还是通过指定 octokit/rest 进行修复

@ddadaal
Copy link
Member

ddadaal commented Jun 11, 2024

咦,我还是在本地试过才merge的。还是更新为@octokit/rest吧。

@pkuhpc-review-bot pkuhpc-review-bot bot added Code-Approved Code Review approved ReadyForMerge Ready for merge and removed Code-ReviewRequested Code Review Requested labels Jun 11, 2024
@ddadaal ddadaal merged commit 5f14ce8 into master Jun 11, 2024
14 checks passed
@ddadaal ddadaal deleted the fix-cli-import-octokit branch June 11, 2024 12:57
OYX-1 pushed a commit that referenced this pull request Jul 4, 2024
### 问题
**在 #1251 中,octokit发生大版本更新导致octokit的导入出现问题, 通过require导入也无法解决**
octokit/octokit.js#2674

![image](https://github.com/PKUHPC/SCOW/assets/43978285/db6d16c8-402d-4c86-8a49-c739c8020ed4)

**octokit/core等不支持octokit.rest方法**

![image](https://github.com/PKUHPC/SCOW/assets/43978285/830e702d-89f6-4114-80b9-cbced9e9fe42)


### 修改
### 可回退octokit版本或者指定 octokit/rest进行修复
**此PR指定依赖为 @octokit/rest 进行修复**
**修复后可正常运行cli命令**

![image](https://github.com/PKUHPC/SCOW/assets/43978285/3c09055c-7e70-4fff-a3e0-e89f8c52929f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code-Approved Code Review approved ReadyForMerge Ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants