Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(mis): 管理系统平台数据统计作业提交用户前十数横坐标改为userName #1206

Merged
merged 17 commits into from
Apr 18, 2024
Merged

feat(mis): 管理系统平台数据统计作业提交用户前十数横坐标改为userName #1206

merged 17 commits into from
Apr 18, 2024

Conversation

usaveh
Copy link
Contributor

@usaveh usaveh commented Apr 11, 2024 •
edited
Loading

做了什么

1.管理系统->平台数据统计->用户提交TOP10，横坐标改为userName

改进前

368260221c753d5de6ce002ca3bafd1

改进后

ad2ee8bb6ccb1897dcd277e3bc29692

@usaveh usaveh linked an issue Apr 11, 2024 that may be closed by this pull request
管理系统->平台数据统计->统计图表横坐标用户ID更改为用户名 #1203
Closed
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 11, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 8a66046

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 15 packages
Name Type
@scow/mis-server Patch
@scow/mis-web Patch
@scow/grpc-api Patch
@scow/protos Patch
@scow/lib-hook Patch
@scow/lib-operation-log Patch
@scow/lib-scheduler-adapter Patch
@scow/lib-server Patch
@scow/audit-server Patch
@scow/portal-server Patch
@scow/portal-web Patch
@scow/ai Patch
@scow/auth Patch
@scow/gateway Patch
@scow/cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkuhpc-review-bot pkuhpc-review-bot bot added the Code-ReviewRequested Code Review Requested label Apr 11, 2024
@pkuhpc-review-bot pkuhpc-review-bot bot requested a review from ddadaal April 11, 2024 05:56
@usaveh usaveh changed the title faet(mis) : 管理系统平台数据统计作业提交用户前十数横坐标改为userName feat（mis）：管理系统平台数据统计作业提交用户前十数横坐标改为userName Apr 11, 2024
@usaveh usaveh changed the title feat（mis）：管理系统平台数据统计作业提交用户前十数横坐标改为userName feat(mis): 管理系统平台数据统计作业提交用户前十数横坐标改为userName Apr 11, 2024
ddadaal
ddadaal requested changes Apr 11, 2024
View reviewed changes
.changeset/great-carrots-refuse.md Outdated Show resolved Hide resolved
apps/mis-server/src/services/job.ts Outdated Show resolved Hide resolved
apps/mis-server/src/services/job.ts Outdated Show resolved Hide resolved
protos/server/job.proto Outdated Show resolved Hide resolved
protos/server/job.proto Outdated Show resolved Hide resolved
protos/server/job.proto Outdated Show resolved Hide resolved
protos/server/job.proto Outdated Show resolved Hide resolved
@pkuhpc-review-bot pkuhpc-review-bot bot added Code-ChangeRequested and removed Code-ReviewRequested Code Review Requested labels Apr 11, 2024
@usaveh usaveh added the Code-ReviewRequested Code Review Requested label Apr 15, 2024
@pkuhpc-review-bot pkuhpc-review-bot bot requested a review from ddadaal April 15, 2024 03:06
ddadaal
ddadaal requested changes Apr 15, 2024
View reviewed changes
apps/mis-server/src/services/job.ts Outdated Show resolved Hide resolved
apps/mis-web/src/pages/admin/statistic.tsx Outdated Show resolved Hide resolved
@pkuhpc-review-bot pkuhpc-review-bot bot added Code-ChangeRequested and removed Code-ReviewRequested Code Review Requested labels Apr 15, 2024
@usaveh usaveh added Code-ReviewRequested Code Review Requested and removed Code-ChangeRequested labels Apr 16, 2024
@pkuhpc-review-bot pkuhpc-review-bot bot requested a review from ddadaal April 16, 2024 09:28
ddadaal
ddadaal requested changes Apr 16, 2024
View reviewed changes
Copy link
Member

@ddadaal ddadaal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

再在server加几个测试用例，输入几个测试用的数据，测试这个API的结果是否正确

apps/mis-server/src/services/job.ts Outdated Show resolved Hide resolved
apps/mis-server/src/services/job.ts Outdated Show resolved Hide resolved
apps/mis-server/src/services/job.ts Show resolved Hide resolved
apps/mis-web/src/pages/api/admin/getUsersWithMostJobSubmissions.ts Show resolved Hide resolved
@pkuhpc-review-bot pkuhpc-review-bot bot added Code-ChangeRequested and removed Code-ReviewRequested Code Review Requested labels Apr 16, 2024
@usaveh usaveh added the Code-ReviewRequested Code Review Requested label Apr 17, 2024
@pkuhpc-review-bot pkuhpc-review-bot bot requested a review from ddadaal April 17, 2024 09:22
@pkuhpc-review-bot pkuhpc-review-bot bot added Code-Approved Code Review approved ReadyForMerge Ready for merge and removed Code-ReviewRequested Code Review Requested labels Apr 17, 2024
ddadaal
ddadaal requested changes Apr 17, 2024
View reviewed changes
apps/mis-server/src/services/job.ts Outdated Show resolved Hide resolved
@pkuhpc-review-bot pkuhpc-review-bot bot added Code-ChangeRequested and removed Code-Approved Code Review approved ReadyForMerge Ready for merge labels Apr 17, 2024
@usaveh usaveh added the Code-ReviewRequested Code Review Requested label Apr 18, 2024
@pkuhpc-review-bot pkuhpc-review-bot bot requested a review from ddadaal April 18, 2024 08:22
@pkuhpc-review-bot pkuhpc-review-bot bot added Code-Approved Code Review approved ReadyForMerge Ready for merge and removed Code-ReviewRequested Code Review Requested labels Apr 18, 2024
@ddadaal ddadaal merged commit 583978b into master Apr 18, 2024
8 checks passed
@ddadaal ddadaal deleted the feat-mis-userId2userName-graph branch April 18, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddadaal ddadaal ddadaal approved these changes

Assignees
No one assigned
Labels
Code-Approved Code Review approved ReadyForMerge Ready for merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

管理系统->平台数据统计->统计图表横坐标用户ID更改为用户名
2 participants
@usaveh @ddadaal