Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ai): 修改 checkpermission 函数对于命令执行错误时的判断逻辑 #1174

Merged
merged 4 commits into from
Mar 22, 2024

Conversation

Miracle575
Copy link
Contributor

@Miracle575 Miracle575 commented Mar 22, 2024

原本对于 ssh 命令执行错误的判断是 判断 stderr 有无输出,但是发现有情况属于 stderr 有输出(warning)但是命令执行成功的情况,所以将此处修改改为判断 code 的值

Copy link

changeset-bot bot commented Mar 22, 2024

🦋 Changeset detected

Latest commit: 1ef8d15

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@scow/ai Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Miracle575 Miracle575 force-pushed the fix-checkpermission branch from e2a8d55 to 8d7f7ef Compare March 22, 2024 06:16
@Miracle575 Miracle575 marked this pull request as ready for review March 22, 2024 06:22
@pkuhpc-review-bot pkuhpc-review-bot bot added the Code-ReviewRequested Code Review Requested label Mar 22, 2024
@pkuhpc-review-bot pkuhpc-review-bot bot requested a review from ddadaal March 22, 2024 06:22
@pkuhpc-review-bot pkuhpc-review-bot bot added Code-Approved Code Review approved ReadyForMerge Ready for merge and removed Code-ReviewRequested Code Review Requested labels Mar 22, 2024
@ddadaal ddadaal merged commit 01cfdae into master Mar 22, 2024
10 checks passed
@ddadaal ddadaal deleted the fix-checkpermission branch March 22, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code-Approved Code Review approved ReadyForMerge Ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants