Support decoding all tag values #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #308 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 20 20
Lines 1662 1657 -5
=========================================
- Hits 1662 1657 -5 ☔ View full report in Codecov by Sentry. |
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
Feb 4, 2024
0.11.0 (2024-02-04) --------------------- - [Updated documentation to refer to RFC 8949](PJK/libcbor#269) - Improvements to `cbor_describe` - [Bytestring data will now be printed as well](PJK/libcbor#281) by [akallabeth](https://github.com/akallabeth) - [Formatting consistency and clarity improvements](PJK/libcbor#285) - [Fix `cbor_string_set_handle` not setting the codepoint count](PJK/libcbor#286) - BREAKING: [`cbor_load` will no longer fail on input strings that are well-formed but not valid UTF-8](PJK/libcbor#286) - If you were relying on the validation, please check the result using `cbor_string_codepoint_count` instead - BREAKING: [All decoders like `cbor_load` and `cbor_stream_decode` will accept all well-formed tag values](PJK/libcbor#308) (bug discovered by [dskern-github](https://github.com/dskern-github)) - Previously, decoding of certain values would fail with `CBOR_ERR_MALFORMATED` or `CBOR_DECODER_ERROR` - This also makes decoding symmetrical with serialization, which already accepts all values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The decoder would only accept tag values in the protected range that were registered when it was originally written. See inline comment for accepting all values is better
Fixes #307
Checklist