GUI: governance, IBD check before opening the proposal creation wizard.

src/qt/pivx/governancewidget.cpp

@@ -142,7 +142,27 @@ void GovernanceWidget::onVoteForPropClicked(const ProposalInfo& proposalInfo)
 
 void GovernanceWidget::onCreatePropClicked()
 {
-    if (!walletModel || !governanceModel) return;
+    if (!walletModel || !governanceModel || !clientModel) return;
+
+    if (!governanceModel->isTierTwoSync()) {
+        inform(tr("Please wait until the node is fully synced"));
+        return;
+    }
+
+    // Do not allow proposals submission 1440 blocks away (1 day) from the next superblock
+    // The budget finalization could have been submitted and the user would never know it, losing the first superblock.
+    // And, do not allow submission until we are 120 blocks (2 hours) after the superblock
+    // just to be sure that the node passed the default chain reorg depth.
+    // future: customizable future superblock height selection (for now, we are automatically using the next superblock).
+    const int chainHeight = clientModel->getLastBlockProcessedHeight();
+    const int nBlocksPerCycle = governanceModel->getNumBlocksPerBudgetCycle();
+    const int nextSuperblock = chainHeight - chainHeight % nBlocksPerCycle + nBlocksPerCycle;
+    const int pastRange = walletModel->isTestNetwork() ? 10 : 1440;
+    const int futureRange = walletModel->isTestNetwork() ? 10 : 120;
+    if (nextSuperblock - pastRange < chainHeight && chainHeight < nextSuperblock + futureRange) {
+        inform(tr("Cannot create proposal, superblock is too close. Need to wait %d blocks").arg(nextSuperblock + 120 - chainHeight));
+        return;
+    }
 
     auto ptrUnlockedContext = std::make_unique<WalletModel::UnlockContext>(walletModel->requestUnlock());
     if (!ptrUnlockedContext->isValid()) {