Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix resurrect alert bug #515

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Conversation

Duddino
Copy link
Member

@Duddino Duddino commented Jan 3, 2025

Abstract

The alerts show variable wasn't saved between refreshes, so alerts that were closed manually, but not expired, were shown again when a new alert was emitted.

Testing

  • Emit an alert that lives for a while (e.g. invalid password when unlocking wallet)
  • Close it manually
  • Emit another alert and assert that only that one is shown

Fixes #492

Copy link

netlify bot commented Jan 3, 2025

Deploy Preview for cheery-moxie-4f1121 ready!

Name Link
🔨 Latest commit 783d420
🔍 Latest deploy log https://app.netlify.com/sites/cheery-moxie-4f1121/deploys/6777eba395919c00084c1e7c
😎 Deploy Preview https://deploy-preview-515--cheery-moxie-4f1121.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Duddino Duddino self-assigned this Jan 3, 2025
@Duddino Duddino added the Bug This is either a bugfix (PR) or a bug (issue). label Jan 3, 2025
Copy link
Member

@JSKitty JSKitty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK 783d420

Spammed various alerts alongside closing them quickly (mostly Error alerts), couldn't replicate the original bug in #492.

@Duddino Duddino merged commit 94a6518 into PIVX-Labs:master Jan 7, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug This is either a bugfix (PR) or a bug (issue).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Old notifications can 'resurrect' in certain conditions
2 participants