Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow non numeric inputs in transfer menus. #514

Merged
merged 2 commits into from
Jan 10, 2025

Conversation

Duddino
Copy link
Member

@Duddino Duddino commented Jan 3, 2025

Abstract

Disallow non numeric inputs in transfer menus
Fix bug where if you inputted a number < 0.1 in stake tab, it would tell you that the minimum amount was 0.1

Testing

  • Test that staking a low amount (e.g. 0.00001) tells you that the min amount is 1
  • Test that inputting a text in any transfer menu numeric input is not allowed

Fix bug where if you inputted a number < 0.1 in stake tab, it would
tell you that the minimum amount was 0.1
@Duddino Duddino self-assigned this Jan 3, 2025
Copy link

netlify bot commented Jan 3, 2025

Deploy Preview for cheery-moxie-4f1121 ready!

Name Link
🔨 Latest commit f6d956a
🔍 Latest deploy log https://app.netlify.com/sites/cheery-moxie-4f1121/deploys/677e6e0eb640700008d31372
😎 Deploy Preview https://deploy-preview-514--cheery-moxie-4f1121.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Duddino Duddino added the Bug This is either a bugfix (PR) or a bug (issue). label Jan 3, 2025
scripts/dashboard/TransferMenu.vue Outdated Show resolved Hide resolved
@Duddino Duddino requested a review from JSKitty January 8, 2025 12:29
Copy link
Member

@JSKitty JSKitty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK f6d956a

Tested on both Desktop and Mobile (mobile being rather important due to Virtual Keyboard changes).

@JSKitty JSKitty merged commit d234df7 into PIVX-Labs:master Jan 10, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug This is either a bugfix (PR) or a bug (issue).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants