Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Governance Budget + Superblock display on iOS Safari #496

Merged
merged 2 commits into from
Dec 14, 2024

Conversation

JSKitty
Copy link
Member

@JSKitty JSKitty commented Dec 12, 2024

Abstract

After dropping 6 IQ points from an hour of random testing, I found that removing the class float-left from the parent div of the upper Governance display fixes the iOS rendering without any noticeable difference on Desktop.

Production (v2.1):
image

Pull Request:
image


Testing

To test this PR, it's suggested to attempt these user flows, or variations of these:

  • (if iPhone owner): check that the Governance tab renders nicely on Safari.
  • (if non-iPhone owner): check that the Governance tab looks fine on your own device(s), both Mobile and Desktop.

If any errors are found, the PR works unexpectedly, or you have viable suggestions to improve the UX or functionality of the PR, let me know!


@JSKitty JSKitty added the Bug This is either a bugfix (PR) or a bug (issue). label Dec 12, 2024
@JSKitty JSKitty self-assigned this Dec 12, 2024
Copy link

netlify bot commented Dec 12, 2024

Deploy Preview for cheery-moxie-4f1121 ready!

Name Link
🔨 Latest commit aecbcc9
🔍 Latest deploy log https://app.netlify.com/sites/cheery-moxie-4f1121/deploys/675c6bbe2cc27a00089bcf66
😎 Deploy Preview https://deploy-preview-496--cheery-moxie-4f1121.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@JSKitty
Copy link
Member Author

JSKitty commented Dec 12, 2024

The iOS portion should be resolved by #496 - I will need Zetty's help or to dust off my old Android devices and simulators to see if I can replicate the FlipDown overflow however.

@JSKitty JSKitty merged commit cd8680e into master Dec 14, 2024
6 checks passed
@JSKitty JSKitty deleted the fix-governance-ios-display branch December 14, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug This is either a bugfix (PR) or a bug (issue).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant