A couple of Wallet refactors

[panleone]

Abstract

This PR contains two wallet refactors (that unfortunately got mixed in the same commit ):

• toHistoricalTXs now takes in input only 1 Transaction instead of an array (we weren't using the array version anymore)
• split the variable chains = 2 in an enum that explicitly tells what is the external chain and what is the change chain. This was done to remove the hardcoded numbers 0 and 1 around Wallet class

---

Testing

IMO is enough to check that tests are still passing

---

[netlify]

✅ Deploy Preview for cheery-moxie-4f1121 ready!

Name	Link
🔨 Latest commit	bd2e694
🔍 Latest deploy log	https://app.netlify.com/sites/cheery-moxie-4f1121/deploys/674ed23e677d3d0008c35cea
😎 Deploy Preview	https://deploy-preview-480--cheery-moxie-4f1121.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[JSKitty]

I hit this when attempting to sync an imported HD wallet (causing the wallet to freeze up).

Weirdly, it did not occur on my second test - it fully synchronised, but reporting this anyway as randomly failing to sync is obviously not good.

[Duddino]

tACK

Fixed by PIVX-Labs/PivxNodeController@b71ca67