-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notification revamp #468
Notification revamp #468
Conversation
✅ Deploy Preview for cheery-moxie-4f1121 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
NOT finished, and contains some testing code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code looks good and works as expected. My only comment is that unit tests should be updated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK 6aea10e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK, with a very minor nit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
re-tACK e2e tests are broken on master too
* [CSS] Update styles * [VUE] New alert layout * [VUE] Update hideAlert name * [CSS] Badge count & and pass count to Alert.vue * [CSS] Update for info and warning icons * Add 'action' data to Alert constructor * Prettier * Testing: hook some of the new functionality in to the frontend NOT finished, and contains some testing code. * [VUE+CSS] Update second button * testing: revert commit used for quicker testing * feat: add ability to run 'actions' from alerts * Prettier * feat: add "Open In Explorer" button to Tx sent Notifications * tests: fix createAlert test * Prettier * tests: test all constructor arguments for createAlert * Update scripts/alerts/Alert.vue * Prettier --------- Co-authored-by: JSKitty <[email protected]> Co-authored-by: Alessandro Rezzi <[email protected]> Co-authored-by: Duddino <[email protected]>
Abstract
As planned, the request to revamp the notifications to give it a better look and better interface for users to interact with.