Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification revamp #468

Merged
merged 22 commits into from
Nov 26, 2024
Merged

Notification revamp #468

merged 22 commits into from
Nov 26, 2024

Conversation

BreadJS
Copy link

@BreadJS BreadJS commented Nov 18, 2024

Abstract

As planned, the request to revamp the notifications to give it a better look and better interface for users to interact with.

Copy link

netlify bot commented Nov 18, 2024

Deploy Preview for cheery-moxie-4f1121 ready!

Name Link
🔨 Latest commit 286476b
🔍 Latest deploy log https://app.netlify.com/sites/cheery-moxie-4f1121/deploys/6745cb31524b6e00082063d6
😎 Deploy Preview https://deploy-preview-468--cheery-moxie-4f1121.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@panleone panleone self-requested a review November 19, 2024 15:26
@panleone panleone added the Enhancement New feature or request label Nov 19, 2024
Copy link
Member

@panleone panleone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good and works as expected. My only comment is that unit tests should be updated

tests/unit/alert.spec.js Show resolved Hide resolved
panleone
panleone previously approved these changes Nov 20, 2024
Copy link
Member

@panleone panleone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK 6aea10e

Duddino
Duddino previously approved these changes Nov 26, 2024
Copy link
Member

@Duddino Duddino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK, with a very minor nit

scripts/alerts/Alert.vue Outdated Show resolved Hide resolved
@Duddino Duddino dismissed stale reviews from panleone and themself via 55f8f80 November 26, 2024 13:14
Copy link
Member

@Duddino Duddino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-tACK e2e tests are broken on master too

@Duddino Duddino merged commit 720d2a9 into master Nov 26, 2024
5 of 6 checks passed
@JSKitty JSKitty deleted the notification-revamp branch November 26, 2024 15:58
Duddino added a commit to Duddino/MyPIVXWallet that referenced this pull request Dec 2, 2024
* [CSS] Update styles

* [VUE] New alert layout

* [VUE] Update hideAlert name

* [CSS] Badge count & and pass count to Alert.vue

* [CSS] Update for info and warning icons

* Add 'action' data to Alert constructor

* Prettier

* Testing: hook some of the new functionality in to the frontend
NOT finished, and contains some testing code.

* [VUE+CSS] Update second button

* testing: revert commit used for quicker testing

* feat: add ability to run 'actions' from alerts

* Prettier

* feat: add "Open In Explorer" button to Tx sent Notifications

* tests: fix createAlert test

* Prettier

* tests: test all constructor arguments for createAlert

* Update scripts/alerts/Alert.vue

* Prettier

---------

Co-authored-by: JSKitty <[email protected]>
Co-authored-by: Alessandro Rezzi <[email protected]>
Co-authored-by: Duddino <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants