Governance vue #375
Merged
Governance vue #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cheery-moxie-4f1121 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Duddino
force-pushed
the
governance-vue
branch
from
7fcfcec to
95b2399
Compare
Duddino
force-pushed
the
governance-vue
branch
from
e2c3925 to
c17d5f7
Compare
Split BudgetAllocated and MonthlyBudget components Fix the render for mobile
Fixed some inconsistencies found when testing
|
Very minor design consistency change: the voting buttons are not the same size, "Yes" is smaller than "No". Prod: PR: |
panleone
requested changes
Nov 4, 2024
panleone
requested changes
Nov 6, 2024
There was a problem hiding this comment.
When opening MPW getProposals throw errors
mpw.js:sourcemap:104538 Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'filter')
at Masternode.getProposals (mpw.js:sourcemap:104538:41)
at async fetchProposals (mpw.js:sourcemap:67700:26)
panleone
requested changes
Nov 6, 2024
There was a problem hiding this comment.
Was able to successfully create a masternode, but there are two issues:
Last seen time is wrong;
When I try to vote a proposal I get the following error
index.js:159 Uncaught (in promise) TypeError: The first argument must be one of type string, Buffer, ArrayBuffer, Array, or Array-like Object. Received type object
at from (index.js:159:1)
at __webpack_modules__../node_modules/buffer/index.js.Buffer.from (index.js:174:1)
at hexToBytes (utils.js:9:18)
at Proxy.getSignedVoteMessage (masternode.js:371:26)
at Proxy.vote (masternode.js:434:1)
at vote (Governance.vue:178:47)
panleone
approved these changes
Dec 2, 2024
Duddino
added a commit
to Duddino/MyPIVXWallet
that referenced
this pull request
Dec 2, 2024
* Initial rewrite * Desktop governance page * Finish governance table for mobile * Change useSettings to store * Add use_masternode * Split masternode component and implement CreateMasternode * Move import wallet inside RestoreWallet component * Add import masternode form * Add import wallet box * Fix masternode import page * Add controller * Finish mn controller * Add create proposal modal * Add automatic proposal confirmation * Fix start error * Add Create Proposal row * Add proposal finalisation * Add vote popup * Flipdown reactive * Split BudgetAllocated and MonthlyBudget components Split BudgetAllocated and MonthlyBudget components Fix the render for mobile * Clean up some dom elements * Fix over budget calculation * Add i18n mock * Add governance tests and test-ids. Fixed some inconsistencies found when testing * Remove unused component * Fix stake balance clearing mocks instead of returing function * Improve translation mock * Add masternode component tests * Re-apply PIVX-Labs#394 to vue (Remove governance dots on mobile) * Fix minor merge errors * Fix local proposal status * Add actual currency * Add finalizeProposalButton v-if to tests * Clean up code * Remove should be fine * Clean up masternode code and update when tab is clicked * Update governance when tab is clicked * Remove legacy exports * Add mastenrode and governance tab to tests * Fix test not passing on machines with different timezones * Fix eslint warnings * Apply PIVX-Labs#392 to vue * Remove console.logs * Fix eslint * Fix tests * Change createAlert * Fix overbudget bug * Fix undefined alert * Fix post-merge import * Add alert when trying to vote without a masternode * Open explorer when clicking on address * Remove openExplorer event * Update test * Revert createMasternode logic * Teleport confirmVoteModal and style cancel button * Fix teleport test * Fix mn starting not working * Fix button height being different * Fix close bug * Fix vote * Readd getBlockbookUrl * Update possible UTXOs on tab click and when creating mn * Add missing import * Fix buttons * Try remove this idk --------- Co-authored-by: Duddino Gatto <[email protected]> Co-authored-by: JSKitty <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abstract
This PR ports the Governance and Masternode tab in vue, massively simplifing the render logic.
TODO
Testing