Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug fix in explicit_broadcast #20

Merged
merged 5 commits into from
Nov 22, 2022

Conversation

Hyunseok-Kim0
Copy link
Collaborator

1. Content and background

#18

2. Summary of corrections

Fixed swap bug in explicit_broadcast and fixed calculation of transpose_perm

Attached code is used to compare outputs between onnx and converted tflite.
dummy_tflite_output_check.zip

3. Before/After (If there is an operating log that can be used as a reference)

dumm1.onnx dumm1.tflite
Screenshot from 2022-11-21 17-43-17 Screenshot from 2022-11-21 17-43-24
dumm2.onnx dumm2.tflite
Screenshot from 2022-11-21 17-43-31 Screenshot from 2022-11-21 17-43-36
dumm4.onnx dumm4.tflite
Screenshot from 2022-11-21 17-43-44 Screenshot from 2022-11-21 17-43-48

4. Issue number (only if there is a related issue)

#18

Copy link
Owner

@PINTO0309 PINTO0309 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the testing and pull requests. It seems that some of the patterns need to be considered in some areas. I would be very happy if you would consider fixing them if possible. :)

onnx2tf/utils/common_functions.py Outdated Show resolved Hide resolved
Copy link
Owner

@PINTO0309 PINTO0309 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I'm doing a regression test now. So far I have not encountered any problems, but I am doing a few additional tests later.

This is a minor correction, but we would appreciate your help in improving the quality of the code.

onnx2tf/utils/common_functions.py Outdated Show resolved Hide resolved
@PINTO0309 PINTO0309 merged commit 225027f into PINTO0309:main Nov 22, 2022
@PINTO0309
Copy link
Owner

PINTO0309 commented Nov 22, 2022

LGTM 😸

No. Model Pass
1 age_googlenet.onnx ✔️
2 arcfaceresnet100-8.onnx ✔️
3 baseline_simplified.onnx ✔️
4 bvlcalexnet-12.onnx ✔️
5 caffenet-12.onnx ✔️
6 densenet-12.onnx ✔️
7 digits.onnx ✔️
8 efficientnet-lite4-11_nchw.onnx ✔️
9 effnet_opset11_dynamic_axis.onnx ✔️
10 emotion-ferplus-8_rename.onnx ✔️
11 face_detection_yunet_2022mar.onnx ✔️
12 face_recognition_sface_2021dec-act_int8-wt_int8-quantized.onnx ✔️
13 face_recognition_sface_2021dec.onnx ✔️
14 gender_googlenet.onnx ✔️
15 inception-v2-9.onnx ✔️
16 mobilenetv2-12.onnx ✔️
17 mosaic_11.onnx ✔️
18 mosaic-9.onnx ✔️
19 movenet_multipose_lightning_192x256_p6.onnx ✔️
20 object_tracking_dasiamrpn_kernel_cls1_2021nov.onnx ✔️
21 object_tracking_dasiamrpn_kernel_r1_2021nov.onnx ✔️
22 object_tracking_dasiamrpn_model_2021nov.onnx ✔️
23 qlinear_conv_tensor_test.onnx ✔️
24 rcnn-ilsvrc13-9.onnx ✔️
25 regnet_x_400mf.onnx ✔️
26 ResNet101-DUC-12.onnx ✔️
27 resnet18-v1-7.onnx ✔️
28 resnet50-v1-12.onnx ✔️
29 resnet50-v2-7.onnx ✔️
30 retinanet-9.onnx ✔️
31 squeezenet1.0-12.onnx ✔️
32 super-resolution-10.onnx ✔️
33 tinyyolov2-8.onnx ✔️
34 version-RFB-640.onnx ✔️
35 yolact_edge_mobilenetv2_550x550.onnx ✔️
36 yolov7_tiny_head_0.768_post_480x640.onnx ✔️
37 yolox_nano_192x192.onnx ✔️
38 yolox_nano_416x416.onnx ✔️
39 yolox_s.onnx ✔️
40 zfnet512-12.onnx ✔️

@Hyunseok-Kim0 Hyunseok-Kim0 deleted the broadcast_develop branch November 22, 2022 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants