Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply strict type checking to Complex suffix #3452

Merged
merged 1 commit into from
Mar 12, 2023
Merged

Apply strict type checking to Complex suffix #3452

merged 1 commit into from
Mar 12, 2023

Conversation

MarkBaker
Copy link
Member

This is:

  • a bugfix
  • a new feature
  • refactoring
  • additional unit tests

Checklist:

  • Changes are covered by unit tests
    • Changes are covered by existing unit tests
    • New unit tests have been added
  • Code style is respected
  • Commit message explains why the change is made (see https://github.com/erlang/otp/wiki/Writing-good-commit-messages)
  • CHANGELOG.md contains a short summary of the change and a link to the pull request if applicable
  • Documentation is updated as necessary

Why this change is needed?

Passing a true/false value to the Complex function as a suffix results in a 0 or 1 being appended to the value, and no suffix applied

So COMPLEX(1.5, 3.5, true) will result in 1.5+3.51, a totally erroneous value.

@MarkBaker MarkBaker merged commit 0875326 into master Mar 12, 2023
@MarkBaker MarkBaker deleted the Minor-Bugfix_Apply-strict-validation-to-Complex-suffix branch March 12, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@MarkBaker