Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow use of # and 0 digit placeholders in fraction masks #3401

Merged
merged 1 commit into from
Feb 25, 2023

Conversation

MarkBaker
Copy link
Member

This is:

  • a bugfix
  • a new feature
  • refactoring
  • additional unit tests

Checklist:

  • Changes are covered by unit tests
    • Changes are covered by existing unit tests
    • New unit tests have been added
  • Code style is respected
  • Commit message explains why the change is made (see https://github.com/erlang/otp/wiki/Writing-good-commit-messages)
  • CHANGELOG.md contains a short summary of the change and a link to the pull request if applicable
  • Documentation is updated as necessary

Why this change is needed?

Fractional masks were only identified by ? digit placeholders around the /; now # and 0 are also recognised as valid digit placeholders for fractions; although the simplistic approach implemented is simply to replace # and 0 with ?.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@MarkBaker MarkBaker merged commit 69e942a into master Feb 25, 2023
@MarkBaker MarkBaker deleted the NumberFormatter-Improved-Fractions branch February 25, 2023 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant