Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add removeCommentByColumnAndRow function #2875

Merged
merged 10 commits into from
Jun 14, 2022
+39 −0
Merged

Add removeCommentByColumnAndRow function #2875

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
391e630
Add removeCommentByColumnAndRow function
dgeppo Jun 8, 2022
1343738
Change removeComment to use CellCoordinate
dgeppo Jun 9, 2022
56ddbc4
Add testRemoveComment
dgeppo Jun 9, 2022
52da0dc
Add use PhpOffice\PhpSpreadsheet\Spreadsheet;
dgeppo Jun 9, 2022
801f529
Update Worksheet.php
dgeppo Jun 9, 2022
861b955
Add feature removeComment
dgeppo Jun 14, 2022
7f62fba
Update the method testRemoveComment
dgeppo Jun 14, 2022
4d2b00d
phpcs fxes
Jun 14, 2022
8e31dba
Update change log
Jun 14, 2022
c749cb5
Merge branch 'master' into master
MarkBaker Jun 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update Worksheet.php
@dgeppo
dgeppo authored Jun 9, 2022
commit 801f5296e9fb2e4d8a30effc58abc0250831818a
2 changes: 1 addition & 1 deletion src/PhpSpreadsheet/Worksheet/Worksheet.php
View file
Original file line number Diff line number Diff line change
@@ -2590,7 +2590,7 @@ public function setComments(array $comments)
*
* @return Comment
*/
public function removeComment($cellCoordinate)
public function removeComment($cellCoordinate):void
{
$cellAddress = Functions::trimSheetFromCellReference(Validations::validateCellAddress($cellCoordinate));