Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix invalid styles in empty columns of added external sheet. #2739

Merged
merged 9 commits into from
Apr 13, 2022
Merged

Fix invalid styles in empty columns of added external sheet. #2739

merged 9 commits into from
Apr 13, 2022

Conversation

mjan4175
Copy link
Contributor

@mjan4175 mjan4175 commented Apr 11, 2022 •
edited
Loading

This is:

- [x] a bugfix
- [ ] a new feature

Checklist:

Why this change is needed?

MarkBaker
MarkBaker reviewed Apr 12, 2022
View reviewed changes
Copy link
Member

@MarkBaker MarkBaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a similar issue with row dimensions? If so, then it might be appropriate to resolve that problem as part of the same PR

@mjan4175
Copy link
Contributor Author

You're right, there was a similar issue with row dimensions.
I added another fix to this PR.

@MarkBaker
Copy link
Member

Thank you for this very useful contribution

@MarkBaker MarkBaker merged commit 4856376 into PHPOffice:master Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkBaker MarkBaker MarkBaker approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mjan4175 @MarkBaker