Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump ezyang/htmlpurifier from 4.13.0 to 4.14.0 #2479

Merged
merged 1 commit into from
Jan 4, 2022

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 1, 2022

Bumps ezyang/htmlpurifier from 4.13.0 to 4.14.0.

Changelog

Sourced from ezyang/htmlpurifier's changelog.

4.14.0, released 2021-12-24 ! Add "background-size" support (#289), contributed by Václav Smítal ! Transform deprecated width attribute when tidying HTML, contributed by Kieran.

  • PHP 8 support, contributed by Maksims Sļotovs.
  • Improved PHP 7.3 compatibility, contributed by kishor.
  • Avoid spurious magic quotes notice in PHP 7.4. Thanks Jasper Zonneveld for the fix.
  • Do not remove thead from table even if there are no tbody/tr (#264). Thanks Marcus Artner for the fix.
  • Fix "Parameter must be an array or an object that implements Countable" (#285)". Thanks Kieran for this fix. . Fix unnecessary reference assignment, handling behavior change from PHP5 and PHP7. Thanks Arkadiusz Biczewski for the fix.
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Jan 1, 2022
@dependabot dependabot bot force-pushed the dependabot/composer/ezyang/htmlpurifier-4.14.0 branch 4 times, most recently from 83ea6cc to c250f74 Compare January 2, 2022 03:45
oleibman pushed a commit to oleibman/PhpSpreadsheet that referenced this pull request Jan 2, 2022
Dependabot opened a number of PRs. Most are successful, but this change is necessary to allow PR PHPOffice#2477 to complete successfully, and that is apparently a necessity for PR PHPOffice#2479.

Phpstan 1.3 objected to:
```php
trigger_error($errorMessage, E_USER_ERROR);
return false;
```
It claims the return statement is unreachable. This isn't precisely true - an error handler might allow the return to be reached. At any rate, I have slightly restructured the code so that Phpstan will not object either with 1.2 or 1.3, which should allow the blocked PRs to succeed. There had been no previous tests for what happens when there is a formula error when suppressFormulaErrors is true.
@oleibman oleibman mentioned this pull request Jan 2, 2022
5 tasks
oleibman added a commit that referenced this pull request Jan 4, 2022
* New Error Reported with Phpstan 1.3

Dependabot opened a number of PRs. Most are successful, but this change is necessary to allow PR #2477 to complete successfully, and that is apparently a necessity for PR #2479.

Phpstan 1.3 objected to:
```php
trigger_error($errorMessage, E_USER_ERROR);
return false;
```
It claims the return statement is unreachable. This isn't precisely true - an error handler might allow the return to be reached. At any rate, I have slightly restructured the code so that Phpstan will not object either with 1.2 or 1.3, which should allow the blocked PRs to succeed. There had been no previous tests for what happens when there is a formula error when suppressFormulaErrors is true.

* Scrutinizer

Didn't like effect of changes which Phpstan liked. Hopefully this will work better.

* Improvement

Eliminate added function.
Bumps [ezyang/htmlpurifier](https://github.com/ezyang/htmlpurifier) from 4.13.0 to 4.14.0.
- [Release notes](https://github.com/ezyang/htmlpurifier/releases)
- [Changelog](https://github.com/ezyang/htmlpurifier/blob/master/NEWS)
- [Commits](ezyang/htmlpurifier@v4.13.0...v4.14.0)

---
updated-dependencies:
- dependency-name: ezyang/htmlpurifier
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/composer/ezyang/htmlpurifier-4.14.0 branch from c250f74 to 50e4a0c Compare January 4, 2022 01:45
@oleibman oleibman merged commit 778e24c into master Jan 4, 2022
@dependabot dependabot bot deleted the dependabot/composer/ezyang/htmlpurifier-4.14.0 branch January 4, 2022 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Development

Successfully merging this pull request may close these issues.

1 participant