Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check array key exists before access in Xlsx.php #1970

Merged
merged 8 commits into from
Apr 18, 2021

Conversation

jarrettj
Copy link
Contributor

@jarrettj jarrettj commented Mar 29, 2021

When loading an xlsx file which has images that use a URL, there's a PHP Notice that is shown.

Added a check for the existence of the array key for accessing.

This is:

- [ x] a bugfix
- [ ] a new feature

Checklist:

Why this change is needed?

Accessing invalid keys in arrays should be checked and skipped over.

When loading an xlsx file which has images that use a URL, there's a PHP Notice that is shown. 

Added a check for the existence of the array key for accessing.
@jarrettj jarrettj changed the title Update Xlsx.php Check array key exists before access in Xlsx.php Mar 29, 2021
jarrettj and others added 5 commits March 29, 2021 15:50
Might as well fix the other similar reference as well.
Fix improper indentation.
@PowerKiKi PowerKiKi merged commit 818b993 into PHPOffice:master Apr 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants