Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve utf-8 named ranges in calculation engine #1522

Merged
merged 7 commits into from
Jun 13, 2020
Merged

Resolve utf-8 named ranges in calculation engine #1522

merged 7 commits into from
Jun 13, 2020

Conversation

MarkBaker
Copy link
Member

@MarkBaker MarkBaker commented Jun 13, 2020 •
edited
Loading

This is:

- [X] a bugfix
- [ ] a new feature

Checklist:

Why this change is needed?

Modify the Calculation engine so that UTF-8 named ranges will be recognised as valid rather than generating an error

@MarkBaker MarkBaker changed the title Resolve utf 8 named ranges in calculation engine Resolve utf-8 named ranges in calculation engine Jun 13, 2020
@arnested
Copy link
Contributor

Works on my sample of (four) real life files. 👏

@MarkBaker MarkBaker merged commit 12dd92b into master Jun 13, 2020
@MarkBaker MarkBaker deleted the Resolve_UTF-8_Named_Ranges_in_Calculation_Engine branch June 21, 2020 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MarkBaker @arnested