Fix branch pruning resolution of non boolean conditions #1167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
| if (isset($storeValue) | ||
| && ( | ||
| !$storeValueAsBool | ||
| || ($storeValue === '#N/A') |
There was a problem hiding this comment.
Hei, not sure about all possible values here.
should you handle these values here as well?
There should be some method to call to check it's error value or not ... 🤔
There was a problem hiding this comment.
Good remark. @PowerKiKi ? Is this the strategy that has been followed elsewhere? Should we proceed on that?
There was a problem hiding this comment.
Functions::isError($cellValue) tests for the listed errors, plus the slightly more esoteric #GETTING_DATA
There was a problem hiding this comment.
Will modify this accordingly
frantzmiccoli
force-pushed
the
fix-branch-pruning
branch
from
5f045ba to
ea7d447
Compare
|
Modified accordingly |
5 tasks
|
LGTM, good job 👍 |
|
Thank you for following up on this work ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is:
Checklist:
Why this change is needed?
Branch pruning was not properly handling non boolean conditions.