-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clickable-url works in Xlsx not in Ods #3660
Comments
oleibman
added a commit
to oleibman/PhpSpreadsheet
that referenced
this issue
Aug 8, 2023
Fix PHPOffice#3660. Code existed to read a hyperlink in a cell for Ods, but did not exist for writing. Hyperlinks pointing within a document use a different representation than for Excel (and therefore for PhpSpreadsheet); read and write will both handle the mapping from one to the other. While researching how to write the text part of a started Xml element, it transpired that writing 2 Ods properties (Company and Category) did not escape their values properly. Confirmed and fixed problem. I do not believe that there is such an exposure for any other writer. As it turns out, Ods Reader was not processing Company or Category properly; that is fixed.
oleibman
added a commit
that referenced
this issue
Aug 12, 2023
Fix #3660. Code existed to read a hyperlink in a cell for Ods, but did not exist for writing. Hyperlinks pointing within a document use a different representation than for Excel (and therefore for PhpSpreadsheet); read and write will both handle the mapping from one to the other. While researching how to write the text part of a started Xml element, it transpired that writing 2 Ods properties (Company and Category) did not escape their values properly. Confirmed and fixed problem. I do not believe that there is such an exposure for any other writer. As it turns out, Ods Reader was not processing Company or Category properly; that is fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This is:
What is the expected behavior?
It is expected that the code suggested in:
change-a-cell-into-a-clickable-url
works the same across formats
What is the current behavior?
Doing:
the Url in cell is correctly save
Doing:
the cell is just text without Url
What are the steps to reproduce?
Attached the results.
What features do you think are causing the issue
...cant say, I would check getHyperlink() or setUrl() output.
Does an issue affect all spreadsheet file formats? If not, which formats are affected?
Ods is affected.
Attached the results files (Xlsx working and Ods not).
2023-07-31_19-23-53_BUG.ods
2023-07-31_19-23-53_BUG.xlsx
Which versions of PhpSpreadsheet and PHP are affected?
I have tested in PHP 8.1.12 and PhpSpreadsheet 1.29.0.
The text was updated successfully, but these errors were encountered: