Cell style modified

[toboul70]

This is:

- [x ] a bug report
- [ ] a feature request
- [ ] **not** a usage question (ask them on https://stackoverflow.com/questions/tagged/phpspreadsheet or https://gitter.im/PHPOffice/PhpSpreadsheet)

What is the expected behavior?

Cell Style not modified

What is the current behavior?

Cell Style modified

What are the steps to reproduce?

I created an xlsx model with Excel with cells like that

I made a reader.
I modified some cells (not the cell I show)
I made a writer.

I opened the file. The cell style was modified like that

File :
Classeur1.xlsx

Please provide a Minimal, Complete, and Verifiable example of code that exhibits the issue without relying on an external Excel file or a web server:

<?php

require __DIR__ . '/vendor/autoload.php';

// Create new Spreadsheet object
$excel  = new PhpOffice\PhpSpreadsheet\Spreadsheet();
$excel  = PhpOffice\PhpSpreadsheet\IOFactory::load($file);
$org    = $excel->getSheetByName('Sheet1');
$org->setCellValue('A1', 'Hello World');

$writer = PhpOffice\PhpSpreadsheet\IOFactory::createWriter($excel, 'Xlsx');
$writer->save($newfile);

Which versions of PhpSpreadsheet and PHP are affected?

PHP 7.3.21 (cli) (built: Aug 4 2020 11:21:19) ( ZTS MSVC15 (Visual C++ 2017) x64 )
Copyright (c) 1997-2018 The PHP Group
Zend Engine v3.3.21, Copyright (c) 1998-2018 Zend Technologies

"name": "phpoffice/phpspreadsheet",
"version": "1.20.0",
"source": {
"type": "git",
"url": "https://github.com/PHPOffice/PhpSpreadsheet.git",
"reference": "44436f270bb134b4a94670f3d020a85dfa0a3c02"

[oleibman]

I can tell you what happened. I need to do some research to figure out what should happen. Fill patterns are assigned a start and end color in the constructor. In your original spreadsheet, the fill pattern is output without a start and end color. In the copied version, it is output with a start and end color, which I believe is correct for some other patterns, but apparently not correct for lightUp and, presumably, other patterns.

[toboul70]

My original file

The copy file

[toboul70]

Another try

My file

The copy file

In the two cases, the background color is set to grey, just under blank.

[toboul70]

Another example :

A cell style modified by PHPExcel :

$sheet->getFill()->setFillType(Fill::FILL_PATTERN_DARKUP);

[lucasres]

I have similar problem, when set a background color in 1.20.0 version dont fill range cell but works well in 1.17.1

$spreadsheet
  ->getActiveSheet()
  ->getStyle("$range1:$range2")
  ->getFill()
  ->setFillType(Fill::FILL_SOLID)
  ->getStartColor()
  ->setARGB($cellColor);

I dont know if same problem.

Which versions of PhpSpreadsheet and PHP are affected?
PHP 7.4.16 (cli) (built: Apr 1 2021 15:55:43) ( NTS )
Copyright (c) The PHP Group
Zend Engine v3.4.0, Copyright (c) Zend Technologies

"name": "phpoffice/phpspreadsheet",
"version": "1.20.0",
"source": {
"type": "git",
"url": "https://github.com/PHPOffice/PhpSpreadsheet.git",
"reference": "44436f270bb134b4a94670f3d020a85dfa0a3c02"
}

[oleibman]

I am guessing that you are specifying $cellColor as a 6-hex-character string. Argb needs to be 8 characters, rgb needs to be 6. This was not enforced in 1.17.1 but is enforced in 1.20.0.