Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop the support for HHVM #556

Merged
merged 1 commit into from
Oct 1, 2019
Merged

Drop the support for HHVM #556

merged 1 commit into from
Oct 1, 2019

Conversation

sunspikes
Copy link
Contributor

@sunspikes sunspikes commented Oct 1, 2019 •
edited
Loading

Fixes #543 and the develop build.

@auto-assign auto-assign bot requested a review from Progi1984 October 1, 2019 11:29
@Progi1984
Copy link
Member

@sunspikes Thank you for your contribution. A small change before merge: Could you update the changelog.md file ? Thanks

@sunspikes
Copy link
Contributor Author

@Progi1984 Done, can you please check if it's ok ?

@Progi1984
Copy link
Member

@sunspikes Perfect

@Progi1984 Progi1984 merged commit eaad91e into PHPOffice:develop Oct 1, 2019
@sunspikes
Copy link
Contributor Author

thank you!!

@Progi1984 Progi1984 added this to the 0.10.0 milestone Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Progi1984 Progi1984 Awaiting requested review from Progi1984

Assignees

@Progi1984 Progi1984

Labels
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

Drop the support for HHVM
2 participants
@sunspikes @Progi1984