Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use PHPUnit\Framework\TestCase instead of PHPUnit_Framework_TestCase #417

Merged
merged 1 commit into from
Dec 29, 2017
Merged

Use PHPUnit\Framework\TestCase instead of PHPUnit_Framework_TestCase #417

merged 1 commit into from
Dec 29, 2017

Conversation

carusogabriel
Copy link
Contributor

@carusogabriel carusogabriel commented Nov 4, 2017 •
edited
Loading

I use the PHPUnit\Framework\TestCase notation instead of PHPUnit_Framework_TestCase while extending our TestCases. This will help us migrate to PHPUnit 6, that no longer support snake case class names.

Just needed to bump PHPUnit version to 4.8.36 for compatibility with namespaces.

@carusogabriel carusogabriel changed the title Updated to PHPUnit 5.7 PHPUnit TestCase com PSR-1 Nov 8, 2017
@carusogabriel carusogabriel changed the title PHPUnit TestCase com PSR-1 Use PHPUnit\Framework\TestCase instead of PHPUnit_Framework_TestCase Nov 9, 2017
@Progi1984 Progi1984 merged commit 30aa22b into PHPOffice:develop Dec 29, 2017
@Progi1984
Copy link
Member

@carusogabriel Thank you for this huge PR.

@Progi1984 Progi1984 added this to the 0.10.0 milestone Dec 29, 2017
@Progi1984 Progi1984 self-assigned this Dec 29, 2017
@carusogabriel carusogabriel deleted the phpunit branch December 29, 2017 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Progi1984 Progi1984

Labels
Source - Pull Request
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@carusogabriel @Progi1984