Composer: Stabilize minimum PHPCompatibility version #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The WP ruleset references the following sniffs: * PHPCompatibility.PHP.NewClasses - been in the repo from before the first tag * PHPCompatibility.PHP.NewConstants - introduced in 8.1.0 * PHPCompatibility.PHP.NewFunctions - been in the repo from before the first tag * PHPCompatibility.PHP.NewInterfaces`- introduced in 7.0.3 * PHPCompatibility.PHP.RemovedExtensions - been in the repo from before the first tag In other words, the minimum version of PHPCompatibility should be 8.1.0 for this release. This will also prevent an update to PHPCompatibility 9.0.0 before we've had a chance to update the ruleset to reflect the new sniff names.
This should be done in their own Travis script.
wimg
approved these changes
Jul 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The WP ruleset references the following sniffs:
In other words, the minimum version of PHPCompatibility should be 8.1.0 for this release.
This will also prevent an update to PHPCompatibility 9.0.0 before we've had a chance to update the ruleset to reflect the new sniff names.
In a separate commit, I've removed
--with-dependenciesfrom the Travis composer validation as the PHPCompatibility composer file has a warning and would fail the build. The build should now pass.