-
-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Travis file and fix build #86
Update Travis file and fix build #86
Conversation
2e65b1d
to
49e4850
Compare
Looks like this fixes part of the issue... PHP5.4 and PHP5.5 need Trusty to build. However, changing the matrix to this:
did not yield the expected result (i.e. Trusty being used...) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions:
- As this repo does not have a committed
composer.lock
file, instead of using thesensiolabs/security-checker
as you are now, you could replace that Composer dependency withroave/security-advisories
.
That way, the check will still be executed, but will be done during thecomposer install
step and it would remove your dependency on an outside URL during your builds. - Adding
dist: trusty
at the top of the script (and removingsudo: false
which is no longer supported) should fix the build failures for PHP 5.4 and 5.5.
Oh and as you're making changes to the Travis script now anyway, why not add a build against |
f89fa5a
to
f55f292
Compare
4e00d60
to
bfc7155
Compare
- Only run secondary checks once (on latest PHP version)
bfc7155
to
12118a3
Compare
@mjrider I'm all done. Can you please review/approve so these changes can be merged to master? They are needed before I can update the other open MRs. |
Special consideration for the php 5.3 build, its 🤪
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Proposed Changes
Currently the Travis build is breaking because the URL used by the security-checker no longer exists.
This MR updates that URL to the new home in order to fix the build.
It also adds a preview for PHP 7.4 and makes minor changes to improve the build step.