-
-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support existing standards packages with subfolders #6
Conversation
Allows plugin installer to search for rulesets that are in a subfolder.
00a7e15
to
be10123
Compare
If this change or similar is accepted, allowing a slightly deeper directory tree for standards, I'll be submitting a change to the Drupal Coder module, asking them to adjust the package type from "library" to "phpcodesniffer-standard". See this fork |
I've been using my changes with the following {
"type": "metapackage",
"minimum-stability": "dev",
"prefer-stable": true,
"config": {
"preferred-install": "dist",
"discard-changes": true
},
"repositories": [
{
"type": "vcs",
"url": "https://github.com/christopher-hopper/coder"
},
{
"type": "vcs",
"url": "https://github.com/christopher-hopper/phpcodesniffer-composer-installer"
}
],
"require": {
"php": ">=5.4",
"mouf/nodejs-installer": "~1.0"
},
"require-dev": {
"dealerdirect/phpcodesniffer-composer-installer": "dev-master",
"frenck/php-compatibility": "*",
"drupal/coder": "dev-8.x-2.x"
}
} Once merged I will be submitting a pull request to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome job!
Proposed Changes
ruleset.xml
exists in a standards sub-folderMotivation
I want to use your excellent installer plugin with the Drupal PHP CodeSniffer standards. Their package uses a subfolder, one deeper than the repository root, which they're unable to change. I am sure there are other examples where Standards may be one or two folders deeper than the current installer allows.
Notify