Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds the ability to set the max depth from the composer.json file #46

Merged
merged 9 commits into from
Oct 25, 2018

Conversation

Potherca
Copy link
Member

@Potherca Potherca commented Feb 1, 2018

Proposed Changes

This MR add the ability to set the max-depth of the finder from the "extra" section of the composer.json file.

Key

The name of the key is phpcodesniffer-max-depth. This can be changed if a better suggestion is made.

Value

The value has the constraint that:

  • It MUST be an integer (not a numeric string)
  • Not smaller or equal to the minimum level (which is 0 or 1 depending on the version of PHPCS installed)
  • Not so large it is converter to scientific notation (which registers as a float) as this triggers an exception from the Finder class.

If the constraint is not met an exception is thrown informing the user.

Related Issues

Fixes #45

@Potherca Potherca requested a review from frenck February 1, 2018 08:32
@Potherca Potherca force-pushed the issues/45/scran-depth-from-extra-section branch from fde5dcc to 99d1bdb Compare February 1, 2018 08:55
@frenck
Copy link
Contributor

frenck commented Mar 14, 2018

Looks good 👍
Missing docs...?

@frenck
Copy link
Contributor

frenck commented Oct 25, 2018

@Potherca Should we move forward with this?

@frenck frenck force-pushed the issues/45/scran-depth-from-extra-section branch from 99d1bdb to 7a6d916 Compare October 25, 2018 11:33
@frenck
Copy link
Contributor

frenck commented Oct 25, 2018

Rebased.

@frenck frenck self-assigned this Oct 25, 2018
@frenck
Copy link
Contributor

frenck commented Oct 25, 2018

Changed it a little @Potherca...
Tested, documented and ready for merge -> I'll go ahead.

@frenck frenck merged commit eaef5f5 into master Oct 25, 2018
@frenck frenck deleted the issues/45/scran-depth-from-extra-section branch October 25, 2018 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants