-
-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds the ability to set the max depth from the composer.json file #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Potherca
force-pushed
the
issues/45/scran-depth-from-extra-section
branch
from
February 1, 2018 08:55
fde5dcc
to
99d1bdb
Compare
Looks good 👍 |
Potherca
modified the milestones:
Next Major Release - v0.5.0,
Release v0.5.0 (Next Major Release)
Oct 15, 2018
@Potherca Should we move forward with this? |
frenck
force-pushed
the
issues/45/scran-depth-from-extra-section
branch
from
October 25, 2018 11:33
99d1bdb
to
7a6d916
Compare
Rebased. |
This was referenced Oct 25, 2018
frenck
approved these changes
Oct 25, 2018
Changed it a little @Potherca... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This MR add the ability to set the max-depth of the finder from the "extra" section of the
composer.json
file.Key
The name of the key is
phpcodesniffer-max-depth
. This can be changed if a better suggestion is made.Value
The value has the constraint that:
0
or1
depending on the version of PHPCS installed)If the constraint is not met an exception is thrown informing the user.
Related Issues
Fixes #45