Switch to PHPCSStandards/PHP_CodeSniffer #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrfnl
force-pushed
the
feature/switch-to-fork-of-phpcs
branch
from
4a5abb6 to
438de24
Compare
The Squizlabs repo has been abandoned. The project continues in a fork in the PHPCSStandards organisation. Note: I'm not changing the version constraints. All tags since 2.0.0 have been recreated in the PHPCSStandards fork, though the package name in those tags has not been changed. Based on tests I've run, the package should install fine when old tags are requested, though if a user has a `composer.json` which _also_ includes `squizlabs/php_codesniffer` in their dependency chain, this means that both will be installed, which could lead to issues. I recommend tagging a release straight-away. This should then allow _our_ dependencies to update their own requirements and version constraints and to release once PHPCS 3.8.0 has been tagged, to prevent these type of problems. Ref: * squizlabs/PHP_CodeSniffer#3932
jrfnl
force-pushed
the
feature/switch-to-fork-of-phpcs
branch
from
438de24 to
626984e
Compare
Potherca
previously approved these changes
Dec 4, 2023
In contrast to earlier information, arrangements are now being made to allow the package to continue under its original name on Packagist. The commit (in the new repo) to rename the package [has been reverted](PHPCSStandards/PHP_CodeSniffer#135).
|
Update: The Composer package name will not change, so while this PR should still be merged at our convenience (after the 3.8.0 release expected this Friday), we will not need to do a release to unblock end-users |
Potherca
approved these changes
Dec 8, 2023
|
PHPCS 3.8.0 has just been released. I've re-retriggered the build and if it passes, I will merge this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a DRAFT PR on purpose as it references releases which have not yet been tagged. Once the PHPCS 3.8.0 tag is available (which contains the Composerreplacedirective), this can/should be merged and released ASAP.Proposed Changes
Switch to PHPCSStandards/PHP_CodeSniffer
The Squizlabs repo has been abandoned. The project continues in a fork in the PHPCSStandards organisation.
Note: I'm not changing the version constraints. All tags since 2.0.0 have been recreated in the PHPCSStandards fork, though the package name in those tags has not been changed.
Based on tests I've run, the package should install fine when old tags are requested, though if a user has a
composer.jsonwhich also includessquizlabs/php_codesnifferin their dependency chain, this means that both will be installed, which could lead to issues.I recommend tagging a release straight-away. This should then allow our dependencies to update their own requirements and version constraints and to release once PHPCS 3.8.0 has been tagged, to prevent these type of problems.Ref:
Tests/PHPCSVersions: add PHPCS 3.7.2/3.8.0 to the mix
Refs:
Revert changes to the Composer package name
In contrast to earlier information, arrangements are now being made to allow the package to continue under its original name on Packagist. The commit (in the new repo) to rename the package has been reverted.