Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added instanceof check to prevent root package from being installed #21

Merged
merged 3 commits into from
Mar 16, 2017
Merged

Added instanceof check to prevent root package from being installed #21

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
125271a
Update Plugin.php
bastianschwarz Mar 15, 2017
050ac1e
Update Plugin.php
bastianschwarz Mar 15, 2017
42eeda1
Update Plugin.php
bastianschwarz Mar 15, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/Plugin.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,6 +287,9 @@ private function updateInstalledPaths()
/**
* Iterates through Composers' local repository looking for valid Coding
* Standard packages.
*
* If the package is the RootPackage (the one the plugin is installed into),
* the package is ignored for now since it needs a different install path logic.
*
* @return array Composer packages containing coding standard(s)
*/
Expand All @@ -302,7 +305,7 @@ function (PackageInterface $package) {
}
);

if ($this->composer->getPackage()->getType() === self::PACKAGE_TYPE) {
if (!$this->composer->getPackage() instanceof \Composer\Package\RootpackageInterface && $this->composer->getPackage()->getType() === self::PACKAGE_TYPE) {
$codingStandardPackages[] = $this->composer->getPackage();
}

Expand Down