GH Actions: fix builds on Windows with PHP 8.2 #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks like the `zip` extension is not available by default on [Windows with PHP 8.2](https://github.com/shivammathur/setup-php/wiki/Php-extensions-loaded-on-windows-2019#php-82), which is causing those builds to fail as the zip extension is needed in the test bootstrap. Looking at the `composer.json` file, we previously identified the `json` and `zip` extensions as `dev` requirements, so let's ensure they will always be [installed and enabled in CI](https://github.com/shivammathur/setup-php#heavy_plus_sign-php-extension-support).
Potherca
approved these changes
May 26, 2022
This was referenced May 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Looks like the
zipextension is not available by default on Windows with PHP 8.2, which is causing those builds to fail as the zip extension is needed in the test bootstrap.Looking at the
composer.jsonfile, we previously identified thejsonandzipextensions asdevrequirements, so let's ensure they will always be installed and enabled in CI.