PlayNiceWithScriptsTest: wrap output expectation in condition #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrfnl
force-pushed
the
feature/playnicewithscripts-test-fix-flacky-php-55-win
branch
from
55f03ef to
8d39be8
Compare
... to allow the function to be called from data providers.
jrfnl
force-pushed
the
feature/playnicewithscripts-test-fix-flacky-php-55-win
branch
from
8d39be8 to
70d65b6
Compare
Yet another one which fails on the notorious PHP 5.5 / Composer 1.x on Windows combination.
jrfnl
force-pushed
the
feature/playnicewithscripts-test-fix-flacky-php-55-win
branch
from
70d65b6 to
f0251b8
Compare
Potherca
approved these changes
May 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Yet another one which intermittently fails on the notorious PHP 5.5 / Composer 1.x on Windows combination.
(saw it fail in two of the test runs for the new PRs, though, like in most cases: not always)