Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH Actions: add builds against Composer 2.2 for PHP 7.2 - 8.x #172

Merged
merged 2 commits into from
Apr 18, 2022

Conversation

jrfnl
Copy link
Member

@jrfnl jrfnl commented Mar 30, 2022

Proposed Changes

Composer 2.3 drops support for PHP < 7.2, so for PHP 5.4 to 7.1, v2 will install Composer 2.2, for PHP 7.2 and up, v2 will install Composer 2.3.
These extra builds make sure the Composer 2.2 LTS version will continue to be 100% supported for PHP 7.2-8.x.

Refs:

Test bootstrap: tweak the version determination regex

Apparently, Composer 2.3.0 dropped the word version from the --version output ;-)

Output on Composer 2.2 and lower:

Composer version 2.2.10 2022-03-29 21:55:35

Composer 2.3 output:

Composer 2.3.0 2022-03-30 11:15:36

Composer 2.3 drops support for PHP < 7.2, so for PHP 5.4 to 7.1, `v2` will install Composer 2.2, for PHP 7.2 and up, `v2` will install Composer 2.3.
These extra builds make sure the Composer 2.2 LTS version will continue to be 100% supported for PHP 7.2-8.x.
@jrfnl jrfnl requested a review from a team March 30, 2022 12:57
@jrfnl jrfnl force-pushed the feature/ghactions-composer-2.3 branch from 4e7f3c2 to 3b417b6 Compare March 30, 2022 13:08
Apparently, Composer 2.3.0 dropped the word `version` from the `--version` output ;-)

Output on Composer 2.2 and lower:
```
Composer version 2.2.10 2022-03-29 21:55:35
```

Composer 2.3 output:
```
Composer 2.3.0 2022-03-30 11:15:36
```
@jrfnl jrfnl force-pushed the feature/ghactions-composer-2.3 branch from 3b417b6 to 9b9e823 Compare March 30, 2022 13:14
@jrfnl
Copy link
Member Author

jrfnl commented Apr 1, 2022

As of Composer 2.3.3, the change in the second commit (test bootstrap) isn't strictly necessary anymore. Still doesn't do any harm either in case someone is running the tests locally and still has Composer 2.3.0 - 2.3.2 installed.

Refs:

@Potherca Potherca merged commit 6357a4b into master Apr 18, 2022
@Potherca Potherca deleted the feature/ghactions-composer-2.3 branch April 18, 2022 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants