TestCase::executeCliCommand(): retry Composer commands on a particular exception #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r exception ... as otherwise a complete build may fail, while the failure is not related to an actual test failure, I've seen this particular issue a couple of times in test runs (most typically with the problematic Composer v1 / PHP 5.5 / Windows combination). Adding a one-time only retry of a command run and only for that particular issue should prevent having to re-run a complete build for this.
Potherca
approved these changes
Mar 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Retry Composer commands on a particular exception as otherwise a complete build may fail, while the failure is not related to an actual test failure,
I've seen this particular issue a couple of times in test runs (most typically with the problematic Composer v1 / PHP 5.5 / Windows combination).
Adding a one-time only retry of a command run and only for that particular issue should prevent having to re-run a complete build for this.