Drop support for PHP 5.3 #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR just and only drops support for PHP 5.3. It doesn't (yet) take advantage of features which were introduced in PHP 5.4, which could now be used.
|
Note: when a decision is taken on this, the required checks for the branch (branch protection settings) will need updating as well. |
Potherca
approved these changes
Jan 27, 2022
Potherca
approved these changes
Feb 6, 2022
|
FYI: I've updated the branch protection settings for the changes in this PR now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This PR just and only drops support for PHP 5.3. It doesn't (yet) take advantage of features which were introduced in PHP 5.4, which could now be used.
Related Issues
Fixes #145