Skip to content

Commit

Permalink
GH Actions: fix builds on Windows with PHP 8.2
Browse files Browse the repository at this point in the history
Looks like the `zip` extension is not available by default on [Windows with PHP 8.2](https://github.com/shivammathur/setup-php/wiki/Php-extensions-loaded-on-windows-2019#php-82), which is causing those builds to fail as the zip extension is needed in the test bootstrap.

Looking at the `composer.json` file, we previously identified the `json` and `zip` extensions as `dev` requirements, so let's ensure they will always be [installed and enabled in CI](https://github.com/shivammathur/setup-php#heavy_plus_sign-php-extension-support).
  • Loading branch information
jrfnl committed May 26, 2022
1 parent aa70e1c commit ca59cf9
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 0 deletions.
1 change: 1 addition & 0 deletions .github/workflows/integrationtest.yml
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,7 @@ jobs:
uses: shivammathur/setup-php@v2
with:
php-version: ${{ matrix.php }}
extensions: json, zip
ini-values: zend.assertions=1, error_reporting=-1, display_errors=On
tools: "composer:${{ matrix.composer }}"
coverage: none
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/quicktest.yml
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ jobs:
uses: shivammathur/setup-php@v2
with:
php-version: ${{ matrix.php }}
extensions: json, zip
ini-values: zend.assertions=1, error_reporting=-1, display_errors=On
tools: "composer:${{ matrix.composer }}"
coverage: none
Expand Down

0 comments on commit ca59cf9

Please sign in to comment.