Skip to content

Commit

Permalink
GH Actions: PHP 8.4 has been released
Browse files Browse the repository at this point in the history
* Builds against PHP 8.4 are no longer allowed to fail.
* Add _allowed to fail_ build against PHP 8.5.

Ref: https://www.php.net/releases/8.4/en.php
  • Loading branch information
jrfnl committed Nov 21, 2024
1 parent c4a2452 commit 4da75a5
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 6 deletions.
9 changes: 6 additions & 3 deletions .github/workflows/integrationtest.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ jobs:
- '8.2'
- '8.3'
- '8.4'
- '8.5'
composer:
- 'v1'
- 'v2'
Expand All @@ -63,6 +64,8 @@ jobs:
# @link https://github.com/composer/composer/issues/10340
- php: '8.4'
composer: 'v1'
- php: '8.5'
composer: 'v1'

include:
# Composer 2.3 drops support for PHP < 7.2, so for PHP 5.4 to 7.1, `v2` will install
Expand Down Expand Up @@ -125,7 +128,7 @@ jobs:

name: "Integration test"

continue-on-error: ${{ matrix.php == '8.4' || matrix.composer == 'snapshot' }}
continue-on-error: ${{ matrix.php == '8.5' || matrix.composer == 'snapshot' }}

steps:
- name: Checkout code
Expand All @@ -145,15 +148,15 @@ jobs:
# Install dependencies and handle caching in one go.
# @link https://github.com/marketplace/actions/install-php-dependencies-with-composer
- name: Install Composer dependencies
if: ${{ matrix.php != '8.4' }}
if: ${{ matrix.php != '8.5' }}
uses: "ramsey/composer-install@v3"
with:
composer-options: '--optimize-autoloader'
# Bust the cache at least once a month - output format: YYYY-MM.
custom-cache-suffix: $(date -u "+%Y-%m")

- name: Install Composer dependencies
if: ${{ matrix.php == '8.4' }}
if: ${{ matrix.php == '8.5' }}
uses: "ramsey/composer-install@v3"
with:
composer-options: '--ignore-platform-reqs --optimize-autoloader'
Expand Down
9 changes: 6 additions & 3 deletions tests/PHPCSVersions.php
Original file line number Diff line number Diff line change
Expand Up @@ -363,19 +363,22 @@ function ($version) {
break;

case '8.3':
case '8.4':
$versions = array_filter(
self::$allPhpcsVersions,
function ($version) {
// PHPCS 3.8.0 is the first PHPCS version with runtime support for PHP 8.3.
// And while officially, PHPCS 3.11.0 is the first PHPCS version with runtime support for PHP 8.4,
// for our purposes, we should be fine with PHPCS 3.8.0 or higher.
return version_compare($version, '3.8.0', '>=');
}
);
break;

case '8.4':
case '8.5':
/*
* At this point in time, it is unclear as of which PHPCS version PHP 8.4 will be supported.
* In other words: tests should only use dev-master/4.x when on PHP 8.4 for the time being.
* At this point in time, it is unclear as of which PHPCS version PHP 8.5 will be supported.
* In other words: tests should only use dev-master/4.x when on PHP 8.5 for the time being.
*/
$versions = array();
break;
Expand Down

0 comments on commit 4da75a5

Please sign in to comment.