Some small improvements to the initial dev setup #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `installed_paths` is set via a custom, the PHPCS native autoloader cannot find non-sniff files provided by an external standard, including the PHPCSUtils files. As PHPCS 3.0.2 is rarely used anymore anyway, let's just not support it. Ref: squizlabs/PHP_CodeSniffer#1591
…more flexible ... to prevent conflicts with projects, be it external standards or end-user projects, which require the plugin themselves as well. Note: Version `0.4.0` is excluded from being installed due to a [bug](PHPCSStandards/composer-installer#33) which made it far less usable. Ref: https://github.com/Dealerdirect/phpcodesniffer-composer-installer/releases
... as it would block unit testing this repo on old PHPCS versions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Composer: set minimum PHPCS 3.x version to
^3.1.0When
installed_pathsis set via a custom, the PHPCS native autoloader cannot find non-sniff files provided by an external standard, including the PHPCSUtils files.As PHPCS 3.0.2 is rarely used anymore anyway, let's just not support it.
Ref: squizlabs/PHP_CodeSniffer#1591
Composer: make the version requirement for the Composer PHPCS plugin more flexible
... to prevent conflicts with projects, be it external standards or end-user projects, which require the plugin themselves as well.
Note: Composer treat minors before
1.0.0as majors, so each supported minor needs to be explicitly allowed.Note: Version
0.4.0is excluded from being installed due to a bug which made it far less usable.Ref: https://github.com/Dealerdirect/phpcodesniffer-composer-installer/releases
Composer: remove the security-advisories
devdependency... as it would block unit testing this repo on old PHPCS versions.