Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NullableTypeDeclarationForDefaultNullValueFixer - handle mixed pseudotype #5484

Merged
merged 1 commit into from
Feb 13, 2021

Conversation

keradus
Copy link
Member

@keradus keradus commented Jan 31, 2021

closes #5483

@keradus keradus added this to the 2.18.3 milestone Jan 31, 2021
@coveralls
Copy link

Coverage Status

Coverage remained the same at 91.929% when pulling f12caa2 on keradus:2.18_fix5483 into ea98c01 on FriendsOfPHP:2.18.

Copy link
Contributor

@kubawerlos kubawerlos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about PHP < 8 where mixed is perfectly fine class name?

@keradus
Copy link
Member Author

keradus commented Feb 2, 2021

I believe we should not touch it, as if we would, we would make someone else code harder to migrate to PHP8.
Usage of future-reserved words, while possible on lower PHP engines, is discouraged.

@keradus keradus merged commit e2c6a1a into PHP-CS-Fixer:2.18 Feb 13, 2021
@keradus keradus deleted the 2.18_fix5483 branch February 13, 2021 22:37
This was referenced Mar 11, 2021
This was referenced Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nullable_type_declaration_for_default_null_value adds ? to mixed
3 participants